Run post_remediation - quote group_names #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.
|
hi @diepes This is a great PR and good catch, unfortunatley the PR is not GPG signed so i am unable to accept it. GPG signature and sign off are both required. Many thanks uk-bolly |
diepes
force-pushed
the
devel
branch
2 times, most recently
from
8271287
to
8278456
Compare
|
hi @uk-bolly I added the signature. Cheers, |
Signed-off-by: Pieter Smit <[email protected]>
|
hi @uk-bolly ,
|
uk-bolly
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Where run_audit.sh is called from ansible quote the group_name, as it can be a list containing a space.
To resolve a error
Issue Fixes:
Please list (using linking) any open issues this PR addresses
N/A
Resolves issue where there is more than one group, and the -g options fails due to space in command.
/opt/UBUNTU20-CIS-Audit/run_audit.sh ... -g ['all_dev', 'webservers_dev']Enhancements:
Please list any enhancements/features that are not open issue tickets
How has this been tested?: